[Sprig App] glowySheep

[atomicra1n]

Author name

Author: atomicra1n

About your game

What is your game about?
You are a shepherd who must get all sheep into the pen. However, your herd has been contaminated by radioactive sheep who will try to infect your herd! Get as many sheep inside the pen and make sure that no radioactive sheep enters the pen.

How do you play your game?
Simply move using WASD, you can restart the level with J. Get as many healthy sheep inside the pen as possible. If a radioactive sheep enters the pen, or all of your sheep get infected, you will lose and the level will restart.

[Copilot]

Pull request overview

This PR introduces "Glowy Sheep", a puzzle/simulation game where players shepherd healthy sheep into a pen while avoiding radioactive sheep that can infect the herd. The game features 9 progressive levels with increasing difficulty and various spatial challenges.

Key changes:

• Complete game implementation with sprite definitions, movement mechanics, and infection system
• 9 levels with different layouts featuring walls, pens, healthy sheep, and radioactive sheep
• AI behavior for sheep (pen attraction, player avoidance, random movement) and infection mechanics

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

[nitpick] The magic number 999 is used as an initial maximum distance value. This should be defined as a named constant like MAX_DISTANCE or INFINITY_DISTANCE to clarify its purpose and make the code more maintainable.

[Copilot]

The magic numbers 5, 4, and 0.15 appear throughout the code without explanation. These control important game mechanics (pen attraction distance, player influence range, random movement probability) and should be defined as named constants at the top of the file (e.g., PEN_ATTRACTION_DISTANCE = 5, PLAYER_INFLUENCE_RANGE = 4, RANDOM_MOVE_PROBABILITY = 0.15) for easier tuning and better code clarity.

[Copilot]

The boundary check destX > 15 || destY > 15 assumes a fixed map size of 16x16, but the actual maps in this game are 14x9 (14 columns, 9 rows). This will allow sheep to move into positions that don't exist on the actual map, potentially causing unexpected behavior. The bounds should match the actual map dimensions or use width() and height() methods if available in the Sprig API.

Suggested change

	if (destX < 0 || destX > 15 || destY < 0 || destY > 15) return false;
	// Map is 14 columns (0-13), 9 rows (0-8)
	if (destX < 0 || destX > 13 || destY < 0 || destY > 8) return false;

[Copilot]

[nitpick] The variable names bads and goods are informal and unclear. Consider using more descriptive names like radioactiveSheep and healthySheep to improve code readability.

Suggested change

	const bads = getAll(radSheep)
	const goods = getAll(sheep)
	goods.forEach(g => {
	bads.forEach(b => {
	const radioactiveSheep = getAll(radSheep)
	const healthySheep = getAll(sheep)
	healthySheep.forEach(g => {
	radioactiveSheep.forEach(b => {

[Copilot]

Using setTimeout in a game loop can cause issues if the player triggers multiple win/loss conditions rapidly. If the player loses twice in quick succession (e.g., by moving quickly), multiple timeouts will be queued, causing the level to reload multiple times. Consider adding a check to prevent multiple simultaneous timeouts or clearing existing timeouts before setting new ones.

[Copilot]

The clearText() call in sfx_infect happens after an 800ms delay, but this text could be overwritten by subsequent infection events or win/loss messages before the timeout completes. This creates a race condition where text management becomes unpredictable. Consider managing text state more explicitly or ensuring only one message is active at a time.

[Copilot]

The function name sfx_infect is misleading - it suggests this function only plays sound effects, but it actually handles the core infection logic (removing healthy sheep, adding radioactive sheep, and displaying text). Consider renaming to infectSheep or convertToRadioactive to better reflect its actual purpose.

Suggested change

	if (dist <= 1) sfx_infect(g.x, g.y);
	})
	})
	}
	function sfx_infect(x, y) {
	if (dist <= 1) infectSheep(g.x, g.y);
	})
	})
	}
	function infectSheep(x, y) {

[Copilot]

The same setTimeout issue exists here. Multiple rapid wins could queue multiple level transitions. While the levelActive flag helps prevent re-entry, it doesn't prevent multiple timeouts from being queued before the first one executes.

[Copilot]

[nitpick] The variable minDst is an unclear abbreviation. Consider using the full word minDistance for better readability.

Suggested change

	let minDst = 999
	allPens.forEach(p => {
	const d = Math.abs(p.x - s.x) + Math.abs(p.y - s.y)
	if (d < minDst) {
	minDst = d
	closest = p
	}
	})
	if (closest) return { tile: closest, dist: minDst }
	let minDistance = 999
	allPens.forEach(p => {
	const d = Math.abs(p.x - s.x) + Math.abs(p.y - s.y)
	if (d < minDistance) {
	minDistance = d
	closest = p
	}
	})
	if (closest) return { tile: closest, dist: minDistance }