[Sprig App] horse rider 2 #3509
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
games/horse-rider-2.js
Outdated
| if (currentLevel !== undefined) { | ||
| setMap(currentLevel); | ||
| } else { | ||
| addText("you win!", { y: 4, color: color`3` }); |
There was a problem hiding this comment.
Bug: The "you win!" message is rendered off-screen because its y coordinate (y: 4) is outside the bounds of the 1-tile-tall final map.
Severity: CRITICAL | Confidence: High
🔍 Detailed Analysis
When the player completes Level 5, the game attempts to display a "you win!" message using addText("you win!", { y: 4, color: color3 }). However, Level 5's map (mappjn```) is only 1 tile tall. The y: 4 coordinate places the text 4 rows below the active map, rendering it completely off-screen and invisible to the player. This prevents visual confirmation of winning the game.
💡 Suggested Fix
Adjust the y coordinate for addText to be within the bounds of the final map, or ensure the final map is tall enough to accommodate y: 4. For example, change y: 4 to y: 0 or y: 1.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: games/horse-rider-2.js#L193
Potential issue: When the player completes Level 5, the game attempts to display a "you
win!" message using `addText("you win!", { y: 4, color: color`3` })`. However, Level 5's
map (`map`pjn```) is only 1 tile tall. The `y: 4` coordinate places the text 4 rows
below the active map, rendering it completely off-screen and invisible to the player.
This prevents visual confirmation of winning the game.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 5950926
fixed the "you win" text (hopefully).
|
Hello, you have submitted 2 PRs, this one and #3506 Which one do you want us to review? We can also review both, but keep in mind you can only get one sprig device. |
I would like you to review this one. Thank you! |
2 participants
Author name
Author: katonamozes
About your game
What is your game about?
get to the portal
How do you play your game?
step with wasd and jump with ijkl