Skip to content

Conversation

@rufus87
Copy link

@rufus87 rufus87 commented Feb 12, 2025

The calculated step configuration gets overwritten by the original step configuration. This small PR fixes it.

@kamranahmedse
Copy link
Owner

Thank you for the PR but what does this solve? Overriding it this way is intentional, configuration set in popover is supposed to override the global configuration of driver

@rufus87
Copy link
Author

rufus87 commented Feb 12, 2025

Hi there,

For example: the value of "progessText" field of "1 of 5" gets overwritten with template {{current}} of {{total}} string. The problem is related to the object destructuring position. It is done at the end of the object, while it should be done on the first position to allow the other calculated values (like 1 of 5) to overwrite.

@FarbrorGarbo
Copy link

I agree that it is wrong approach to do the overriding of the data the way suggested in this PR. It breaks the intention. However, rufus87 is correct with the issue, but the bug is in the Driver class itself by doing the calculation of the text before the spread is done.

I did my own PR as a fun part of Hacktoberfest. I know that it is late for Hacktoberfest and this project is not part of it. So please label my contribution with the hacktoberfest-accepted label anyway if it is accepted. No merge needed if I'm correct - just accepted. Otherwise no worries, just fun to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants