[GitLab] Delete VM on retry #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ispasov
force-pushed
the
is/delete-vm-on-retry
branch
from
6066e38 to
2104a6b
Compare
spikeburton
approved these changes
Jul 7, 2025
GitLab automatically retries the prepare step 3 times. However it never calls cleanup between retries so we can end up with 3 orphaned VMs. Delete the VMs on failure.
ispasov
force-pushed
the
is/delete-vm-on-retry
branch
from
2104a6b to
68a0f04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitLab automatically retries the prepare step 3 times.
However it never calls cleanup between retries so we can end up with 3 orphaned VMs.
Delete the VMs on failure.
Testing
Contact me for testing details