-
-
Notifications
You must be signed in to change notification settings - Fork 457
Implement Shift+Arrow cell selection resizing for sheet UI #4962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Implement Shift+Arrow cell selection resizing for sheet UI #4962
Conversation
|
Hey @Hardyx07, can you please update the PR description? |
Hi @Anish9901 , I’ve updated the PR description with more details as requested. Please let me know if anything else is needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be many inconsistencies between the behavior of Google Sheets and the behavior of this PR.
For example say you have this selection
Shift+Down works. Okay.
But the following keyboard shortcuts do not work the same way that Google Sheets works:
- Shift+Up
- Shift+Right
- Shift+Left
As I play with different shapes of selections it's very easy to find lots of different inconsistencies. I won't spend time trying to list them all out. This needs a lot more QA.
Also, looking at the code. Wow, that's much more code than I would expect this implementation to be. I've not spent time reading through it at all (because clearly some logic needs to be fixed first). But so many levels deep of if/else statements is a major code smell here. It's hard to read code like that and reason about it. My hunch is that you need to rethink the approach.
|
@seancolsen Got it. I’ll rethink the approach and clean up the architecture. |
Fixes #4906
This PR adds the ability to expand or shrink your cell selection using Shift + Arrow keys in the sheet UI, as requested in #4906.
Technical details
Testing instructions
Checklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin