-
-
Notifications
You must be signed in to change notification settings - Fork 457
Improve color of the Mathesar link in forms #5002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Improve color of the Mathesar link in forms #5002
Conversation
…line on hover/focus for Mathesar link in forms
zackkrida
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Ashwath-Palanisamy, the changes you've made do not actually work, as the contents of the a tag you've styled are SVGs the underline doesn't appear correctly:
Please test your changes visually in Mathesar before resubmitting this PR. I would suggest considering a bottom border to produce the underline rather than text-decoration in this case 😄
|
@Ashwath-Palanisamy can you please post a screenshot of the logo with your changes? |
|
@Anish9901 The attached screenshots show the Mathesar link in both light and dark themes. The link uses the base text color (--color-fg-base) with a bottom-border underline on hover for better visibility and accessibility.
Without hover
with hover
|




Fixes #4769
This PR updates the Mathesar link on the form fillout page to use the theme’s base text color and adds an underline on hover and focus. It ensures the link looks visually aligned and accessible in both light and dark themes.
Technical details
--color-fg-base) instead of muted text.form-branding ato avoid global overridesChecklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin