Skip to content

Conversation

@Ashwath-Palanisamy
Copy link

@Ashwath-Palanisamy Ashwath-Palanisamy commented Nov 22, 2025

Fixes #4769

This PR updates the Mathesar link on the form fillout page to use the theme’s base text color and adds an underline on hover and focus. It ensures the link looks visually aligned and accessible in both light and dark themes.

Technical details

  • Updated link color to use the theme’s base text color (--color-fg-base) instead of muted text
  • Added underline on hover and focus states for accessibility
  • Scoped styles within .form-branding a to avoid global overrides
  • Verified appearance in both light and dark themes

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ashwath-Palanisamy, the changes you've made do not actually work, as the contents of the a tag you've styled are SVGs the underline doesn't appear correctly:

Image

Please test your changes visually in Mathesar before resubmitting this PR. I would suggest considering a bottom border to produce the underline rather than text-decoration in this case 😄

@Anish9901
Copy link
Member

@Ashwath-Palanisamy can you please post a screenshot of the logo with your changes?

@Anish9901 Anish9901 marked this pull request as draft December 1, 2025 10:19
@Ashwath-Palanisamy
Copy link
Author

Ashwath-Palanisamy commented Dec 1, 2025

@Anish9901 The attached screenshots show the Mathesar link in both light and dark themes.

The link uses the base text color (--color-fg-base) with a bottom-border underline on hover for better visibility and accessibility.

In the “with hover” screenshots the mouse cursor isn’t visible in the capture, but the link is in its hover state

Without hover

image image

with hover

image image

@Anish9901 Anish9901 marked this pull request as ready for review December 1, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve color of the Mathesar link in forms

3 participants