Skip to content

Conversation

@radheshpai87
Copy link
Contributor

Fixes #5059

This PR fixes inconsistent date/time parsing when pasting values into cells. Previously, pasted dates were parsed by the server using its locale settings, often resulting in dates different from what the user entered.

Technical details

Applied the existing DateTimeFormatter system (already used in edit mode) to the paste flow. Now when users paste date/time values into cells with custom format metadata (e.g., European date format), the frontend parses them correctly before sending to the backend.

Changes made to /src/components/sheet/clipboard/paste.ts:

  1. Added imports:

    • getColumnMetadataValue from @mathesar/api/rpc/columns to read column format settings
    • DateTimeFormatter and DateTimeSpecification from @mathesar/utils/date-time to parse dates
  2. Created parseDateTimeValue() helper:

    • Detects if column is date/datetime/time type
    • Reads column metadata (date_format, time_format)
    • Uses DateTimeFormatter to parse pasted value respecting those settings
    • Returns canonical ISO format to backend
  3. Updated prepareStructuredCellValue():

    • Detects date/datetime/time columns
    • Routes pasted values through new parser
    • Gracefully falls back to raw value if parsing fails

Screenshots

  • Before
image
  • After (Now after pasting it shows like this)
image

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse temporal values on the front end after pasting

1 participant