Skip to content

Conversation

@Ahamed1846
Copy link
Contributor

Improve datetime parsing for loose timestamp formats (#5060)

Fixes #5060

This PR enhances date/time parsing so that Mathesar correctly handles valid timestamp inputs that omit leading zeros or seconds. Previously, entries such as "2000-01-01 9:00:00" or "2000-01-01 09:00" were not parsed and were sent to PostgreSQL unchanged, causing unexpected timezone shifts.

Technical details

Problem

parseWithSpec matched only strict timestamp formats and rejected variants without leading zeros or without seconds. When parsing failed, the unparsed string was sent directly to PostgreSQL, resulting in incorrect values for timestamptz columns.

Fix

Additional timestamp format variants were included in
DateTimeSpecification so that:

  • Hours without leading zero (H:mm:ss, H:mm)
  • Timestamps without seconds (YYYY-MM-DD HH:mm)
  • Timestamps using single-digit hour (YYYY-MM-DD H:mm:ss)

are now correctly parsed and converted to canonical form.

Behavior Changes

  • Valid timestamp inputs with missing leading zeros now parse correctly.
  • Values are consistently normalized before being sent to the backend.
  • No changes were made to date-only parsing or time-only behavior.

Files touched

  • mathesar_ui/src/utils/date-time/DateTimeSpecification.ts
  • mathesar_ui/src/utils/date-time/DateTimeFormatter.ts

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try more date and time formats when parsing temporal values on the front end

1 participant