Improve datetime parsing for loose timestamp formats #5068
+42
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve datetime parsing for loose timestamp formats (#5060)
Fixes #5060
This PR enhances date/time parsing so that Mathesar correctly handles valid timestamp inputs that omit leading zeros or seconds. Previously, entries such as "2000-01-01 9:00:00" or "2000-01-01 09:00" were not parsed and were sent to PostgreSQL unchanged, causing unexpected timezone shifts.
Technical details
Problem
parseWithSpecmatched only strict timestamp formats and rejected variants without leading zeros or without seconds. When parsing failed, the unparsed string was sent directly to PostgreSQL, resulting in incorrect values for timestamptz columns.Fix
Additional timestamp format variants were included in
DateTimeSpecificationso that:H:mm:ss,H:mm)YYYY-MM-DD HH:mm)YYYY-MM-DD H:mm:ss)are now correctly parsed and converted to canonical form.
Behavior Changes
Files touched
mathesar_ui/src/utils/date-time/DateTimeSpecification.tsmathesar_ui/src/utils/date-time/DateTimeFormatter.tsChecklist
Update index.md).developbranch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin