Fix/button appearance split

[MohammedTharikS]

issue number #4901

Summary

This PR splits the default button appearance into two distinct appearances: control and input. This resolves visual inconsistencies where buttons with the same "default" appearance looked different depending on their context, particularly in Dropdown and Select components.

Technical details

• Type Definition: Added 'control' and 'input' to the Appearance type in commonTypes.ts
• Button Component:
  • Created btn-control variant using --color-*-control CSS variables
  • Created btn-input variant using --color-*-input CSS variables
  • Kept btn-default as an alias to btn-control for backward compatibility
  • Changed default appearance from 'default' to 'control'
• Dropdown Component:
  • Updated default triggerAppearance to 'control'
  • Removed style overrides in Dropdown.scss that were causing visual inconsistencies
• Select Component:
  • Updated default triggerAppearance to 'input' (appropriate for form inputs)
• Tests: Updated all affected test files to reflect the new appearance types

All 351 tests pass successfully.

Screenshots

Before

Buttons with "default" appearance had inconsistent styles:

• Control buttons (like action buttons) and input buttons (like dropdowns in forms) looked different despite using the same appearance value

After

• Control buttons consistently use the control appearance with --color-*-control variables
• Input-like components (Select) use the input appearance with --color-*-input variables
• Visual consistency maintained across light and dark themes

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors. 1 Letterman Drive Suite D4700 San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.