Execution Tests: Update tolerances for half precision trig functions #7992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tex3d
approved these changes
Dec 9, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Might still be a bit tight for the general case, but if this is enough for current HW, we can update it if necessary in the future.
bob80905
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the tolerances for half precision trig functions with DXIL vectors. The D3D spec only notes the tolerance range for fp32. That fp32 error tolerance is not sufficient for halfs. After some further discussion we opted to use 0.003 as the tolerance for most half precision trig ops. For trig ops with a range that approaches infinity in either direction, we instead use 2 ULP.
Fixes #7936