Skip to content

Enhance isJS check in getNewImportFixes function #62840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johnsoncodehk wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −4
Open

Enhance isJS check in getNewImportFixes function #62840

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e52bfc4
Enhance isJS check in getNewImportFixes function
johnsoncodehk Dec 4, 2025
04f5cc2
Update src/services/codefixes/importFixes.ts
johnsoncodehk Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/services/codefixes/importFixes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,7 @@ import {
RequireOrImportCall,
RequireVariableStatement,
sameMap,
ScriptKind,
SemanticMeaning,
shouldUseUriStyleNodeCoreModules,
single,
Expand Down Expand Up @@ -1255,7 +1256,6 @@ function getNewImportFixes(
preferences: UserPreferences,
fromCacheOnly?: boolean,
): { computedWithoutCacheCount: number; fixes: readonly (FixAddNewImport | FixAddJsdocTypeImport)[]; } {
const isJs = hasJSFileExtension(sourceFile.fileName);
const compilerOptions = program.getCompilerOptions();
const moduleSpecifierResolutionHost = createModuleSpecifierResolutionHost(program, host);
const getChecker = createGetChecker(program, host);
Expand All @@ -1276,9 +1276,17 @@ function getNewImportFixes(
if (rejectNodeModulesRelativePaths && pathContainsNodeModules(moduleSpecifier)) {
return undefined;
}
if (!importedSymbolHasValueMeaning && isJs && usagePosition !== undefined) {
// `position` should only be undefined at a missing jsx namespace, in which case we shouldn't be looking for pure types.
return { kind: ImportFixKind.JsdocTypeImport, moduleSpecifierKind, moduleSpecifier, usagePosition, exportInfo, isReExport: i > 0 };
if (!importedSymbolHasValueMeaning && usagePosition !== undefined) {
const scriptKind = isFullSourceFile(sourceFile)
? sourceFile.scriptKind
: host.getScriptKind?.(sourceFile.fileName);
const isJs = scriptKind !== undefined
? scriptKind === ScriptKind.JS || scriptKind === ScriptKind.JSX
: hasJSFileExtension(sourceFile.fileName);
if (isJs) {
// `position` should only be undefined at a missing jsx namespace, in which case we shouldn't be looking for pure types.
return { kind: ImportFixKind.JsdocTypeImport, moduleSpecifierKind, moduleSpecifier, usagePosition, exportInfo, isReExport: i > 0 };
}
}
const importKind = getImportKind(sourceFile, exportInfo.exportKind, program);
let qualification: Qualification | undefined;
Expand Down