Skip to content

clipboard-x11: request selection at init #17098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kasper93 merged 2 commits into from
Dec 4, 2025
+14 −4
Merged

clipboard-x11: request selection at init #17098

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0dc591
clipboard-x11: use separate properties to receive primary and clipboard
na-na-hi Dec 3, 2025
59fcdfa
clipboard-x11: request selection at init
na-na-hi Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions player/clipboard/clipboard-x11.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,15 @@ static bool clipboard_x11_init(struct clipboard_x11_priv *x11, bool xwayland)
MP_FATAL(x11, "Xfixes init failed\n");
goto err;
}

// XFixesSelectionNotifyEvent does not give an initial notification
// so request selection here
XConvertSelection(x11->display, XA(x11, CLIPBOARD), XA(x11, UTF8_STRING),
XA(x11, MPV_CLIPBOARD), x11->window, CurrentTime);
XConvertSelection(x11->display, XA_PRIMARY, XA(x11, UTF8_STRING),
XA(x11, MPV_PRIMARY), x11->window, CurrentTime);
XFlush(x11->display);

return true;

err:
Expand Down Expand Up @@ -186,11 +195,12 @@ static bool clipboard_x11_dispatch_events(struct clipboard_x11_priv *x11, int64_
MP_TRACE(x11, "XEvent: %d\n", event.type);
if (event.type == x11->XFixesSelectionNotifyEvent) {
XFixesSelectionNotifyEvent *ev = (XFixesSelectionNotifyEvent *)&event;
if (ev->owner != x11->window &&
(ev->selection == XA(x11, CLIPBOARD) || ev->selection == XA_PRIMARY))
{
if (ev->owner != x11->window && ev->selection == XA(x11, CLIPBOARD)) {
XConvertSelection(x11->display, ev->selection, XA(x11, UTF8_STRING),
XA(x11, MPV_CLIPBOARD), x11->window, CurrentTime);
} else if (ev->owner != x11->window && ev->selection == XA_PRIMARY) {
XConvertSelection(x11->display, ev->selection, XA(x11, UTF8_STRING),
XA(x11, MPV_SELECTION), x11->window, CurrentTime);
XA(x11, MPV_PRIMARY), x11->window, CurrentTime);
}
} else if (event.type == SelectionRequest) {
clipboard_x11_handle_selection_request(x11, &event);
Expand Down