-
-
Notifications
You must be signed in to change notification settings - Fork 33.6k
GH-141565: Add async code awareness to Tachyon #141533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@pablogsal Opening as draft for now so we can discuss 😄 |
c80b975 to
5e64bc0
Compare
5e64bc0 to
7315953
Compare
…cpython into async-tachyon
64d7be6 to
64ccb1a
Compare
b45ad36 to
fca9c88
Compare
|
@pablogsal Just took a look at the changes and things look really solid. I just pushed some more commits to fix a test/some UX inconsistencies but overall I think things look great. Really like the all/running modes too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Excellent work @savannahostrowski. This is going to make such a big difference ❤️
|
@savannahostrowski there are some problems in windows and slow machines that I am investigating |
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 47ebc11 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141533%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
I pushed a change with some windows fixes and tests and looks like this fixes all buildbots so I am merging. Congrats! This is amazing :) |
Before:

With

--async-aware:And just for posterity, here's what
pstreereturns for the program: