Skip to content

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Nov 13, 2025

Before:
image

With --async-aware:
Screenshot 2025-11-14 at 9 49 19 AM

And just for posterity, here's what pstree returns for the program:

└── (T) Task-1
    └──  main /Users/savannah/code/cpython/sandbox/test_simple_async.py:59
        └──  wait_for /Users/savannah/code/cpython/Lib/asyncio/tasks.py:488
            └── (T) Supervisor
                └──  supervisor /Users/savannah/code/cpython/sandbox/test_simple_async.py:41
                    ├── (T) Worker-0
                    │   └──  worker /Users/savannah/code/cpython/sandbox/test_simple_async.py:24
                    │       └── (T) LeafTask-0
                    │           └──  leaf_work /Users/savannah/code/cpython/sandbox/test_simple_async.py:13
                    │               └──  sleep /Users/savannah/code/cpython/Lib/asyncio/tasks.py:702
                    ├── (T) Worker-1
                    │   └──  worker /Users/savannah/code/cpython/sandbox/test_simple_async.py:24
                    │       └── (T) LeafTask-1
                    │           └──  leaf_work /Users/savannah/code/cpython/sandbox/test_simple_async.py:13
                    │               └──  sleep /Users/savannah/code/cpython/Lib/asyncio/tasks.py:702
                    └── (T) Worker-2
                        └──  worker /Users/savannah/code/cpython/sandbox/test_simple_async.py:24
                            └── (T) LeafTask-2
                                └──  leaf_work /Users/savannah/code/cpython/sandbox/test_simple_async.py:13
                                    └──  sleep /Users/savannah/code/cpython/Lib/asyncio/tasks.py:702```

@savannahostrowski
Copy link
Member Author

@pablogsal Opening as draft for now so we can discuss 😄

@savannahostrowski savannahostrowski changed the title Add async code awareness to Tachyon GH-141565: Add async code awareness to Tachyon Nov 14, 2025
@pablogsal pablogsal marked this pull request as ready for review November 25, 2025 00:56
@savannahostrowski
Copy link
Member Author

@pablogsal Just took a look at the changes and things look really solid. I just pushed some more commits to fix a test/some UX inconsistencies but overall I think things look great. Really like the all/running modes too.

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Excellent work @savannahostrowski. This is going to make such a big difference ❤️

@pablogsal
Copy link
Member

@savannahostrowski there are some problems in windows and slow machines that I am investigating

@pablogsal pablogsal added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 6, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 47ebc11 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141533%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 6, 2025
@pablogsal pablogsal merged commit 56a442d into python:main Dec 6, 2025
101 of 109 checks passed
@pablogsal
Copy link
Member

I pushed a change with some windows fixes and tests and looks like this fixes all buildbots so I am merging. Congrats! This is amazing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants