Use sudo for become method #1624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tasks related to creating directories are run on mounted directories for local VMs. Using `sudo` as the `become_method` can provide better guarantees that the UID/GIDs mapping are preserved properly. This might only matter for VM solutions like LXD but it shouldn't change solutions like Lima that already work correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tasks related to creating directories are run on mounted directories for local VMs. Using
sudoas thebecome_methodcan provide better guarantees that the UID/GIDs mapping are preserved properly.This might only matter for VM solutions like LXD but it shouldn't change solutions like Lima that already work correctly.