General update to the "Supported media players" list #397
Conversation
comment: this would probably fare better as a github wiki in the long term...
There was a problem hiding this comment.
Thank you for your PR! I've left some notes that should be addressed.
In my opinion working on this document is not really worth the time, you should instead focus on the wiki that you talked about in the Discord. I'm still happy to merge it, since you've put the work in. Thank you for that!
A tip for you for future PRs: Try to change only what needs changes, as the maintainer has to go through everything that you updated and that process takes time. For some changes the review can take significantly more time than actually making the change. I appreciate your effort, but e.g. reordering the footnotes in the table means that I have to go through all of them to check if they are still correct, for no apparent gain. (I didn't check those, the table should just be removed)
I encourage you to work on the wiki, then I'll add it to the music-presence GitHub org and we can just link to it and the player support website in this document. 😄
| > **Only the ["Additional Notes"](#additional-notes) and ["Players with known issues"](#players-with-known-issues) sections are actively maintained.** | ||
| > An accurate list of media players is available [here](https://musicpresence.pocha.moe/) - thank you to our community moderator [@mercurialworld](https://github.com/mercurialworld) for making this site! |
There was a problem hiding this comment.
It probably makes more sense to link to the wiki in various places once it exists and label it maintained, when there is someone to actually maintain it. I don't think maintaining this document via PRs is the way to go.
There was a problem hiding this comment.
So I wouldn't call this actively maintained here.
| ## Additional notes | ||
|
|
||
| ### MusicBee | ||
| --- |
There was a problem hiding this comment.
I think this table should just be removed entirely instead of putting any work in to update it.
| Windows and Linux offer specific tools for media players to report their playback information, named SMTC and MPRIS respectively. | ||
| These are the essential features that allow Music Presence to function on Windows and Linux. | ||
|
|
||
| While foobar2000 reports basic information out of the box, | ||
| this plugin will add the album name and a progress bar to your status: | ||
| https://github.com/ungive/foo_mediacontrol | ||
| Unfortunately, some players do not utilize this correctly, while others report nothing at all. | ||
| For these cases, various people have written helper software to "close the gap". |
There was a problem hiding this comment.
While nice, I think most people who visit here just want to know what they need to download. 😅
| ### MusicBee | ||
|
|
||
| ### AIMP | ||
| MusicBee requires [this plugin](https://github.com/HenryPDT/mb_MediaControl) to work. |
There was a problem hiding this comment.
Maybe noting some of the quirks of the plugin might make sense, so people know what to expect. I think there were issues with the song sometimes not updating, missing or delayed cover images and badly functioning media keys. Can't say with 100% certainty though.
| ### AIMP | ||
|
|
||
| AIMP requires [this plugin](https://www.aimp.ru/forum/index.php?topic=63341) to work. | ||
| While it generally works fine, it does apparently provide wrong playback information at times. |
There was a problem hiding this comment.
Why "at times"? It never does it, iirc. The use of the word "apparently" is superfluous imo.
I think the original description of its quirks were fine.
| VLC requires [this plugin](https://github.com/spmn/vlc-win10smtc) to work. | ||
| As of right now, this plugin reports neither cover images, nor an accurate playback position. |
There was a problem hiding this comment.
Only keep the first line here.
Thumbnail reporting was added here: spmn/vlc-win10smtc@69b69c0
I also added playback position reporting in this PR: spmn/vlc-win10smtc#7
| Some players report their playback position with an outdated “as of” timestamp. | ||
| This will show up as an elapsed timer that’s wildly ahead of reality (e.g., “13:04 elapsed” right after resuming a 3-minute track). | ||
| It’s most noticeable after pausing and later resuming: Discord keeps the stale timestamp, so the counter jumps. |
There was a problem hiding this comment.
Use straight quotation marks: " and '
2 participants
Changes made
General
Media Player List
Additional Notes
Players with known issues
Comment
As mentioned on Discord, this would probably fare better as a GitHub wiki in the long term...
I might look into it this weekend.