Performance: use IsSingleShard() check in pushDerived instead of just engine.EqualUnique opcode
#18974
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the
pushDerivedfunction inroute_planning.goto consider all single-shard routing scenarios, not just those using theengine.EqualUniqueopcode.IsSingleShard()method checks if a route is a single shard route by looking at its opcode. The method returnstruefor the following opcodes:Unsharded,DBA,Next,EqualUnique, andReference.Reference -
vitess/go/vt/vtgate/engine/routing.goRelated Issue(s)
Fixes #18952
Checklist
Deployment Notes
AI Disclosure