-
Notifications
You must be signed in to change notification settings - Fork 91
[Model] Add Qwen-Image-Edit #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
|
The account who enabled Codex for this repo no longer has access to Codex. Please contact the admins of this repo to enable Codex again. |
Signed-off-by: samithuang <[email protected]>
could you modify the png for qwen x vllm-omni |
|
@hsliuustc0106 added |
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
|
The account who enabled Codex for this repo no longer has access to Codex. Please contact the admins of this repo to enable Codex again. |
| ) | ||
|
|
||
|
|
||
| def get_diffusion_pre_process_func(od_config: OmniDiffusionConfig): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we unify get_diffusion_pre_process_func and get_diffusion_post_process_func? They have some common code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion, common code is extracted into a function
| postprocess_start_time = time.time() | ||
| result = self.post_process_func(output.output) | ||
| postprocess_time = time.time() - postprocess_start_time | ||
| logger.info(f"Post-processing completed in {postprocess_time:.4f} seconds") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's used for performance profiling. just two lines of info log. i think it doesn't matter
vllm_omni/diffusion/models/qwen_image/pipeline_qwen_image_edit.py
Outdated
Show resolved
Hide resolved
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
| def load_weights(self): | ||
| self.load_transformer() | ||
|
|
||
| def load_transformer(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use weight loader introduced in #157
Signed-off-by: samithuang <[email protected]>
Signed-off-by: Samit <[email protected]>
Gaohan123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!


PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Add Qwen-Image-Edit, as described #187
Test Plan
python image_edit.py \ --image qwen_bear.png \ --prompt "Let this mascot dance under the moon, surrounded by floating stars and poetic bubbles such as 'Be Kind'" \ --output output_image_edit.png \ --num_inference_steps 50 \ --cfg_scale 4.0Test Result
Input image:
Edited image:

prompt: "Let this mascot dance under the moon, surrounded by floating stars and poetic bubbles such as 'Be Kind'"
prompt: "Add a white art board written with colorful text 'vLLM-Omni' on grassland. Add a paintbrush in the bear's hands. position the bear standing in front of the art board as if painting"
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)