Skip to content

Conversation

@SamitHuang
Copy link
Collaborator

@SamitHuang SamitHuang commented Dec 4, 2025

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Add Qwen-Image-Edit, as described #187

Test Plan

python image_edit.py \
    --image qwen_bear.png \
    --prompt "Let this mascot dance under the moon, surrounded by floating stars and poetic bubbles such as 'Be Kind'" \
    --output output_image_edit.png \
    --num_inference_steps 50 \
    --cfg_scale 4.0

Test Result

Input image:

qwen_bear

Edited image:
output_image_edit2

prompt: "Let this mascot dance under the moon, surrounded by floating stars and poetic bubbles such as 'Be Kind'"

output_image_edit_omni

prompt: "Add a white art board written with colorful text 'vLLM-Omni' on grassland. Add a paintbrush in the bear's hands. position the bear standing in front of the art board as if painting"


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
@chatgpt-codex-connector
Copy link

The account who enabled Codex for this repo no longer has access to Codex. Please contact the admins of this repo to enable Codex again.

@SamitHuang SamitHuang marked this pull request as draft December 4, 2025 10:39
Signed-off-by: samithuang <[email protected]>
@hsliuustc0106
Copy link
Collaborator

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Add Qwen-Image-Edit, as described #187

TODOs:

  • align output with diffusers
  • run pre-processing in DiffusionEngine (or API Server after online serving supported)

Test Plan

python image_edit.py \
    --image qwen_bear.png \
    --prompt "Let this mascot dance under the moon, surrounded by floating stars and poetic bubbles such as 'Be Kind'" \
    --output output_image_edit.png \
    --num_inference_steps 50 \
    --cfg_scale 4.0

Test Result

Input image:

qwen_bear Edited image: output_image_edit2

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

could you modify the png for qwen x vllm-omni

@SamitHuang
Copy link
Collaborator Author

@hsliuustc0106 added

Signed-off-by: samithuang <[email protected]>
Signed-off-by: samithuang <[email protected]>
@SamitHuang SamitHuang requested a review from ZJY0516 December 5, 2025 09:16
@SamitHuang SamitHuang marked this pull request as ready for review December 5, 2025 09:16
@chatgpt-codex-connector
Copy link

The account who enabled Codex for this repo no longer has access to Codex. Please contact the admins of this repo to enable Codex again.

@SamitHuang SamitHuang changed the title [Model][WIP] Add Qwen-Image-Edit [Model] Add Qwen-Image-Edit Dec 5, 2025
)


def get_diffusion_pre_process_func(od_config: OmniDiffusionConfig):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we unify get_diffusion_pre_process_func and get_diffusion_post_process_func? They have some common code

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion, common code is extracted into a function

postprocess_start_time = time.time()
result = self.post_process_func(output.output)
postprocess_time = time.time() - postprocess_start_time
logger.info(f"Post-processing completed in {postprocess_time:.4f} seconds")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this log?

Copy link
Collaborator Author

@SamitHuang SamitHuang Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's used for performance profiling. just two lines of info log. i think it doesn't matter

def load_weights(self):
self.load_transformer()

def load_transformer(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use weight loader introduced in #157

Signed-off-by: samithuang <[email protected]>
@SamitHuang SamitHuang requested a review from Gaohan123 December 8, 2025 03:31
Copy link
Collaborator

@Gaohan123 Gaohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Gaohan123 Gaohan123 enabled auto-merge (squash) December 8, 2025 06:32
@Gaohan123 Gaohan123 merged commit e8ea478 into vllm-project:main Dec 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new model add new model

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants