Skip to content

Conversation

@theashiot
Copy link

@wildfly-ci
Copy link

Hello, theashiot. I'm waiting for one of the admins to verify this patch with /ok-to-test in a comment.

@darranl
Copy link
Contributor

darranl commented Sep 19, 2025

/ok-to-test

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14794 outcome was FAILURE using a merge of 42820c4
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:01:28

@wildfly-ci
Copy link

Core -> Full Integration Build 14671 outcome was FAILURE using a merge of 42820c4
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:01:50

@wildfly-ci
Copy link

Core -> Full Integration (with SecurityManager) Build 14991 outcome was FAILURE using a merge of 42820c4
Summary: Exit code 1 (Step: Build core (Maven)) (new) Build time: 00:01:56

@github-actions
Copy link

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

@rhusar
Copy link
Member

rhusar commented Nov 21, 2025

There is very little value in the PR like this as this is not mergeable on it's own. You need a change to go along with the schema bump.

@wildfly-ci
Copy link

Core -> Full Integration (with SecurityManager) Build 15116 outcome was FAILURE using a merge of 82a81d5
Summary: Tests failed: 1 (1 new), passed: 8172, ignored: 114 Build time: 04:47:13

Failed tests

org.jboss.as.test.clustering.cluster.web.remote.FineHotRodPersistenceWebFailoverTestCase.testGracefulSimpleFailover: java.lang.AssertionError: expected:<200> but was:<500>
	at org.jboss.as.test.clustering.cluster.web.AbstractWebFailoverTestCase.testFailover(AbstractWebFailoverTestCase.java:160)
	at org.jboss.as.test.clustering.cluster.web.AbstractWebFailoverTestCase.testGracefulSimpleFailover(AbstractWebFailoverTestCase.java:76)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor26.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor25.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor24.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor6.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor3.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at org.infinispan.server.test.junit4.InfinispanServerRule$1.evaluate(InfinispanServerRule.java:68)
------- Stdout: -------
node-1 2025-11-21 14:30:51,592 INFO  [org.jboss.as.repository] (management-handler-thread - 4) WFLYDR0001: Content added at location /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-1/standalone/data/content/6d/54ba3211e73512b36db9377d2ed218c699f2f7/content
node-1 2025-11-21 14:30:51,596 INFO  [org.jboss.as.server.deployment] (MSC service thread 1-3) WFLYSRV0027: Starting deployment of "FineHotRodPersistenceWebFailoverTestCase.war" (runtime-name: "FineHotRodPersistenceWebFailoverTestCase.war")
node-1 2025-11-21 14:30:51,713 WARN  [org.jboss.as.dependency.private] (MSC service thread 1-3) WFLYSRV0018: Deployment "deployment.FineHotRodPersistenceWebFailoverTestCase.war" is using a private module ("org.infinispan.core") which may be changed or removed in future versions without notice.
node-1 2025-11-21 14:30:51,718 INFO  [org.jboss.weld.deployer] (MSC service thread 1-8) WFLYWELD0003: Processing weld deployment FineHotRodPersistenceWebFailoverTestCase.war
node-1 2025-11-21 14:30:51,733 INFO  [org.jboss.as.ejb3.deployment] (MSC service thread 1-8) WFLYEJB0473: JNDI bindings for session bean named 'TopologyChangeListenerBean' in deployment unit 'deployment "FineHotRodPersistenceWebFailoverTestCase.war"' are as follows:

	java:global/FineHotRodPersistenceWebFailoverTestCase/TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener
	java:app/FineHotRodPersistenceWebFailoverTestCase/TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener
	java:module/TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener
	java:jboss/exported/FineHotRodPersistenceWebFailoverTestCase/TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener
	ejb:/FineHotRodPersistenceWebFailoverTestCase/TopologyChangeListenerBean!org.jboss.as.test.clustering.TopologyChangeListener
	java:global/FineHotRodPersistenceWebFailoverTestCase/TopologyChangeListenerBean
	java:app/FineHotRodPersistenceWebFailoverTestCase/TopologyChangeListenerBean
	java:module/TopologyChangeListenerBean

node-1 2025-11-21 14:30:51,856 INFO  [org.infinispan.HOTROD] (ServerService Thread Pool -- 99) ISPN004021: Infinispan version: Infinispan 'Feelin Blue' 15.2.6.Final
node-1 2025-11-21 14:30:51,856 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 99) WFLYCLINF0029: Started remote cache container 'web'.
node-1 2025-11-21 14:30:51,879 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 106) WFLYCLINF0002: Started default-server cache from web container
node-1 2025-11-21 14:30:51,879 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 106) WFLYCLINF0002: Started default-server cache from web container
node-1 2025-11-21 14:30:51,920 INFO  [org.infinispan.CONTAINER] (ServerService Thread Pool -- 99) ISPN000025: wakeUpInterval is <= 0, not starting expired purge thread
node-1 2025-11-21 14:30:51,928 INFO  [org.infinispan.CLUSTER] (non-blocking-thread--p26-t5) [Context=FineHotRodPersistenceWebFailoverTestCase.war] ISPN100008: Updating cache members list [node-1], topology id 2


@github-actions github-actions bot removed the Stale label Nov 22, 2025
@theashiot
Copy link
Author

Thanks, @rhusar for the feedback! Creating a separate PR for version bump was a conscious decision. Otherwise, if different people are introducing changes to Elytron, they will make the bump in their own PR and thus it will be a duplication of effort and . This particular Issue + PR was created in anticipation of https://issues.redhat.com/browse/ELY-2921. Also, we had a discussion about this topic here: #wildfly-elytron > Elytron schema bump to 19.

Darran also mentioned about having a single place for coordinating elytron schema bumps in this PR: #6557 (review).

Please LMK what you think!

@darranl the test failure (org.jboss.as.test.clustering.cluster.web.remote.FineHotRodPersistenceWebFailoverTestCase failure) seem to be unrelated to the version bump, but i could be wrong. Can you please have a look?

Thanks,
ashwin

@rhusar
Copy link
Member

rhusar commented Nov 24, 2025

Thanks, @rhusar for the feedback! Creating a separate PR for version bump was a conscious decision. Otherwise, if different people are introducing changes to Elytron, they will make the bump in their own PR and thus it will be a duplication of effort and . This particular Issue + PR was created in anticipation of https://issues.redhat.com/browse/ELY-2921. Also, we had a discussion about this topic here: #wildfly-elytron > Elytron schema bump to 19.

OK, no problem. Though, introducing a new schema in a well-designed subsystem should be trivial and virtually only couple of LOC changed + XSD copy.

Also, just to state the obvious, not all changes in the model result in change in the schema change. Also, a schema change in most cases require model bump as well.

Also, this is only adding a particular stability level (community) while others may be developing a feature at a different stability, making this change unusable by them (and eventually require a rebase anyway).

Darran also mentioned about having a single place for coordinating elytron schema bumps in this PR: #6557 (review).

OK, I guess it's useful for visibility, but it's quite common to share topic branches without an existing PR (which is why git is so great!)

Please LMK what you think!

OK, np, you clearly know what you are doing 👍🏼

@darranl the test failure (org.jboss.as.test.clustering.cluster.web.remote.FineHotRodPersistenceWebFailoverTestCase failure) seem to be unrelated to the version bump, but i could be wrong. Can you please have a look?

This is actually ours, safely ingore that one; tracked as https://issues.redhat.com/browse/WFLY-21180

@darranl
Copy link
Contributor

darranl commented Nov 24, 2025

@rhusar +1 to the comment from @theashiot we have multiple developers who may work on this subsystem concurrently, the approach we use is one coordinates in chat that they will handle the schema bump and then all other changes will build upon that bump.

In the past we had people undertaking the same work and then having to fix their branches depending on who's bump made it in first.

@theashiot theashiot marked this pull request as ready for review November 25, 2025 10:04
@theashiot
Copy link
Author

Thanks, @rhusar, @darranl! I've removed an unnecessary newline from my previous changes and marked this PR as ready for review.

best,
ashwin

@pferraro
Copy link
Contributor

pferraro commented Dec 2, 2025

@rhusar +1 to the comment from @theashiot we have multiple developers who may work on this subsystem concurrently, the approach we use is one coordinates in chat that they will handle the schema bump and then all other changes will build upon that bump.

Topic branches?

If there are multiple developers working on branches for the same model and/or schema version, they would typically base their respective locally branches on some common branch, e.g. theashiot:WFCORE-7350.
It's fine to use the pull request system as a means of publicising your topic branch, but such a pull request should be submitted as a draft - and should never be merged independently.

@rhusar
Copy link
Member

rhusar commented Dec 3, 2025

@rhusar +1 to the comment from @theashiot we have multiple developers who may work on this subsystem concurrently, the approach we use is one coordinates in chat that they will handle the schema bump and then all other changes will build upon that bump.

Topic branches?

If there are multiple developers working on branches for the same model and/or schema version, they would typically base their respective locally branches on some common branch, e.g. theashiot:WFCORE-7350. It's fine to use the pull request system as a means of publicising your topic branch, but such a pull request should be submitted as a draft - and should never be merged independently.

Yes, that's what I am calling a topic branch such as this theashiot:WFCORE-7350, short-lived branch created to develop a specific functionality. The topic being support for the new schema. Topic branches can be based off of each other. (The other way to do this is a have a 'elytron-develop' branch in upstream that would include this and other would base their topic branches off of that. But that's not worth it for such a small thing as schema bumps).

When I submitted my original comments, the PR was in draft state and that's why I didn't bring it up since I assumed that the understanding is shared, that things that are not in the mergeable state should be drafts.

@theashiot
Copy link
Author

Thanks, @pferraro, @rhusar, moving this to daft. Also, as suggested by @darranl, i'm going to add a commit with a model bump. And change the order of commits so that the commit for model bump is before the schema bump. Then others can base their changes off of the commit which require.

best,
ashwin

@theashiot theashiot marked this pull request as draft December 3, 2025 10:00
@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14942 outcome was FAILURE using a merge of 6b6034c
Summary: Tests failed: 1 (1 new), passed: 5462, ignored: 88 Build time: 03:37:16

Failed tests

org.jboss.as.test.clustering.cluster.ejb.timer.DistributedTimerServiceTestCase.test: java.lang.AssertionError: class org.jboss.as.test.clustering.cluster.ejb.timer.beans.AutoPersistentTimerBean={node-1=[]}. Actual: 0
	at org.jboss.as.test.clustering.cluster.ejb.timer.AbstractTimerServiceTestCase.test(AbstractTimerServiceTestCase.java:303)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
------- Stdout: -------
node-2 2025-12-03 15:30:42,983 INFO  [org.jboss.modules] (main) JBoss Modules version 2.1.6.Final
node-2 2025-12-03 15:30:43,449 INFO  [org.jboss.msc] (main) JBoss MSC version 1.5.6.Final
node-2 2025-12-03 15:30:43,567 INFO  [org.jboss.as] (MSC service thread 1-2) WFLYSRV0049: WildFly Preview 39.0.0.Beta1-SNAPSHOT (WildFly Core 31.0.0.Beta3-SNAPSHOT) starting
node-2 2025-12-03 15:30:44,757 INFO  [org.wildfly.security] (Controller Boot Thread) ELY00001: WildFly Elytron version 2.7.0.Final
node-2 2025-12-03 15:30:45,752 INFO  [org.jboss.as.server] (Controller Boot Thread) WFLYSRV0039: Creating http management service using socket-binding (management-http)
node-2 2025-12-03 15:30:45,769 INFO  [org.xnio] (MSC service thread 1-7) XNIO version 3.8.16.Final
node-2 2025-12-03 15:30:45,777 INFO  [org.xnio.nio] (MSC service thread 1-7) XNIO NIO Implementation Version 3.8.16.Final
node-2 2025-12-03 15:30:45,833 INFO  [org.jboss.as.connector.subsystems.datasources] (ServerService Thread Pool -- 48) WFLYJCA0004: Deploying JDBC-compliant driver class org.h2.Driver (version 2.4)
node-2 2025-12-03 15:30:45,840 INFO  [org.jboss.remoting] (MSC service thread 1-2) JBoss Remoting version 5.0.31.Final
node-2 2025-12-03 15:30:45,886 INFO  [org.wildfly.extension.elytron.oidc._private] (ServerService Thread Pool -- 57) WFLYOIDC0001: Activating WildFly Elytron OIDC Subsystem
node-2 2025-12-03 15:30:45,900 INFO  [org.wildfly.extension.health] (ServerService Thread Pool -- 58) WFLYHEALTH0001: Activating Base Health Subsystem
node-2 2025-12-03 15:30:45,907 INFO  [org.jboss.as.jaxrs] (ServerService Thread Pool -- 62) WFLYRS0016: RESTEasy version 7.0.0.Final
node-2 2025-12-03 15:30:45,907 INFO  [org.wildfly.extension.io] (ServerService Thread Pool -- 60) WFLYIO001: Worker 'default' has auto-configured to 8 IO threads with 64 max task threads based on your 4 available processors
node-2 2025-12-03 15:30:45,915 INFO  [org.jboss.as.clustering.infinispan] (ServerService Thread Pool -- 59) WFLYCLINF0001: Activating Infinispan subsystem.
node-2 2025-12-03 15:30:45,929 INFO  [org.jboss.as.connector] (MSC service thread 1-6) WFLYJCA0009: Starting Jakarta Connectors Subsystem (WildFly/IronJacamar 3.0.16.Final)
node-2 2025-12-03 15:30:45,944 INFO  [org.jboss.as.connector.deployers.jdbc] (MSC service thread 1-6) WFLYJCA0018: Started Driver service with driver-name = h2
node-2 2025-12-03 15:30:45,988 INFO  [org.jboss.as.jsf] (ServerService Thread Pool -- 68) WFLYJSF0007: Activated the following Jakarta Server Faces Implementations: [main]
node-2 2025-12-03 15:30:46,006 INFO  [org.jboss.as.clustering.jgroups] (ServerService Thread Pool -- 65) WFLYCLJG0001: Activating JGroups subsystem. JGroups version 5.4.12
node-2 2025-12-03 15:30:46,025 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-8) WFLYELY00023: KeyStore file '/opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-2/standalone/configuration/application.keystore' does not exist. Used blank.
node-2 2025-12-03 15:30:46,040 INFO  [org.wildfly.extension.microprofile.config.smallrye] (ServerService Thread Pool -- 71) WFLYCONF0001: Activating MicroProfile Config Subsystem
node-2 2025-12-03 15:30:46,053 WARN  [org.wildfly.extension.elytron] (MSC service thread 1-8) WFLYELY01084: KeyStore /opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-2/standalone/configuration/application.keystore not found, it will be auto-generated on first use with a self-signed certificate for host localhost
node-2 2025-12-03 15:30:46,143 INFO  [org.wildfly.extension.microprofile.jwt.smallrye] (ServerService Thread Pool -- 72) WFLYJWT0001: Activating MicroProfile JWT Subsystem
node-2 2025-12-03 15:30:46,150 INFO  [org.jboss.as.naming] (ServerService Thread Pool -- 74) WFLYNAM0001: Activating Naming Subsystem
node-2 2025-12-03 15:30:46,207 INFO  [org.jboss.as.naming] (MSC service thread 1-4) WFLYNAM0003: Starting Naming Service
node-2 2025-12-03 15:30:46,209 INFO  [org.jboss.as.mail.extension] (MSC service thread 1-5) WFLYMAIL0001: Bound mail session [java:jboss/mail/Default]
node-2 2025-12-03 15:30:46,214 WARN  [org.jboss.as.txn] (ServerService Thread Pool -- 81) WFLYTX0013: The node-identifier attribute on the /subsystem=transactions is set to the default value. This is a danger for environments running multiple servers. Please make sure the attribute value is unique.
node-2 2025-12-03 15:30:46,265 INFO  [org.jboss.as.webservices] (ServerService Thread Pool -- 83) WFLYWS0002: Activating WebServices Extension
node-2 2025-12-03 15:30:46,297 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-8) WFLYUT0003: Undertow 2.4.0.Alpha1 starting
node-2 2025-12-03 15:30:46,369 INFO  [org.jboss.as.ejb3] (MSC service thread 1-4) WFLYEJB0481: Strict pool slsb-strict-max-pool is using a max instance size of 64 (per class), which is derived from thread worker pool sizing.
node-2 2025-12-03 15:30:46,370 INFO  [org.jboss.as.ejb3] (MSC service thread 1-4) WFLYEJB0482: Strict pool mdb-strict-max-pool is using a max instance size of 16 (per class), which is derived from the number of CPUs on this host.
node-2 2025-12-03 15:30:46,486 INFO  [org.wildfly.extension.undertow] (ServerService Thread Pool -- 82) WFLYUT0014: Creating file handler for path '/opt/buildAgent/work/e8e0dd9c7c4ba60/full/testsuite/integration/clustering/target/wildfly-2/welcome-content' with options [directory-listing: 'false', follow-symlink: 'false', case-sensitive: 'true', safe-symlink-paths: '[]']
node-2 2025-12-03 15:30:46,492 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-4) WFLYUT0012: Started server default-server.
node-2 2025-12-03 15:30:46,494 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) Queuing requests.
node-2 2025-12-03 15:30:46,495 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0018: Host default-host starting
node-2 2025-12-03 15:30:46,645 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-7) WFLYUT0006: Undertow AJP listener ajp listening on 127.0.0.1:8109
node-2 2025-12-03 15:30:46,648 INFO  [org.wildfly.extension.undertow] (MSC service thread 1-3) WFLYUT0006: Undertow HTTP listener default listening on 127.0.0.1:8180


@darranl
Copy link
Contributor

darranl commented Dec 8, 2025

@theashiot At this point please don't change the SHAs of either of these commits so other PRs can depend upon them

@rhusar
Copy link
Member

rhusar commented Dec 8, 2025

@theashiot At this point please don't change the SHAs of either of these commits so other PRs can depend upon them

Just to mention, git is smart enough to skip the same commit even if the SHA differs. Also, even then, people can easily rebase last commit on top of the branch with no breakage, e.g. git rebase --onto theashiot/WFCORE-7350 HEAD~1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants