-
-
Notifications
You must be signed in to change notification settings - Fork 478
[WFCORE-7362] Add CSP header to management endpoints #6521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 29.x
Are you sure you want to change the base?
Conversation
|
Im not sure if this should be done for Common#sendError and DomainUtil as well ? |
|
Core -> Full Integration Build 14916 outcome was FAILURE using a merge of 780d0f7 |
|
Core -> Full Integration Build 14605 outcome was FAILURE using a merge of 780d0f7 |
|
Core -> WildFly Preview Integration Build 14719 outcome was FAILURE using a merge of 780d0f7 |
|
|
||
| public static final String DEFAULT_CSP_HEADER = "default-src 'self';"; | ||
| private final HttpHandler next; | ||
| private String headerContent = DEFAULT_CSP_HEADER; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field and the 2 arg constructor should be dropped and we just use the constant.
If we ever have a situation where we actually need to make this configurable we can add the logic for it then.
This class's maven module is not meant for use outside of the server kernel so we should optimize it for that use.
780d0f7 to
130aed2
Compare
|
Core -> Full Integration Build 14917 outcome was FAILURE using a merge of 130aed2 |
|
Core -> WildFly Preview Integration Build 14720 outcome was FAILURE using a merge of 130aed2 |
|
Core -> Full Integration Build 14606 outcome was FAILURE using a merge of 130aed2 |
|
Jobs fail in weird way: |
|
@baranowb The 29.x branch has already been released, and we do not plan to release again from here. Please, could you close this PR and open it again against |
|
There has been no activity on this PR for 45 days. It will be auto-closed after 90 days. |
Issue: https://issues.redhat.com/browse/WFCORE-7362