Skip to content

Conversation

@baranowb
Copy link
Contributor

@baranowb baranowb added the 29.x PRs meant for 29.x (corresponding to WildFly 37.x) label Sep 18, 2025
@baranowb
Copy link
Contributor Author

Im not sure if this should be done for Common#sendError and DomainUtil as well ?

@wildfly-ci
Copy link

Core -> Full Integration Build 14916 outcome was FAILURE using a merge of 780d0f7
Summary: Exit code 1 (Step: Build and test full with JDK 17 (Maven)) (new) Build time: 00:02:12

@wildfly-ci
Copy link

Core -> Full Integration Build 14605 outcome was FAILURE using a merge of 780d0f7
Summary: Exit code 1 (Step: Build and test full with JDK 21 (Maven)) (new) Build time: 00:02:48

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14719 outcome was FAILURE using a merge of 780d0f7
Summary: Exit code 1 (Step: Build & test full (Maven)) (new) Build time: 00:02:55

@yersan yersan removed the 29.x PRs meant for 29.x (corresponding to WildFly 37.x) label Sep 18, 2025

public static final String DEFAULT_CSP_HEADER = "default-src 'self';";
private final HttpHandler next;
private String headerContent = DEFAULT_CSP_HEADER;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field and the 2 arg constructor should be dropped and we just use the constant.

If we ever have a situation where we actually need to make this configurable we can add the logic for it then.

This class's maven module is not meant for use outside of the server kernel so we should optimize it for that use.

@wildfly-ci
Copy link

Core -> Full Integration Build 14917 outcome was FAILURE using a merge of 130aed2
Summary: Exit code 1 (Step: Build and test full with JDK 17 (Maven)) Build time: 00:02:22

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14720 outcome was FAILURE using a merge of 130aed2
Summary: Exit code 1 (Step: Build & test full (Maven)) Build time: 00:02:30

@wildfly-ci
Copy link

Core -> Full Integration Build 14606 outcome was FAILURE using a merge of 130aed2
Summary: Exit code 1 (Step: Build and test full with JDK 21 (Maven)) Build time: 00:02:41

@baranowb
Copy link
Contributor Author

Jobs fail in weird way:
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
06:22:18  [ERROR] Non-resolvable import POM: Could not find artifact org.wildfly.core:wildfly-core-parent:pom:29.0.1.Final-SNAPSHOT in local-mirror @ line 510, column 19

@yersan
Copy link
Contributor

yersan commented Sep 23, 2025

@baranowb The 29.x branch has already been released, and we do not plan to release again from here. Please, could you close this PR and open it again against main branch?

@github-actions
Copy link

github-actions bot commented Nov 8, 2025

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

@github-actions github-actions bot added the Stale label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants