-
-
Notifications
You must be signed in to change notification settings - Fork 485
Rework pipeline data structure #4626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@qwerty287 Why is that breaking? Because of the env var change? |
|
Yes, env var change and it also changes the json for the pipeline model |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@woodpecker-ci/maintainers could I ask again for reviews here? This is open for almost a year now. And it simplifies the pipeline structure a lot. (Also feel free to directly modify the branch if there's something to fix) |
|
Thanks for updating to main again. I will try to have a look at it and will do some testing. Could you try to test with a copy of our ci.woodpecker-ci.org db as well. Last time it had some hickups with the migrations. |
supersedes #3421
closes #2971
closes #4677
closes #4195
Currently, our pipeline model has fields like the message, title etc., but every field is used differently, dependending on the event.
This PR changes this and splits these reused fields to have a more clear pipeline model.
The model now has fields like:
and similar.
Advantages:
Especially 3 and 4 and are the enhancement parts here, as we can now store both context and commit message and not only one.