ignore hook removal when repo is already deleted on github

[tuxmainy]

Hi,
this fixes an "internal error" when trying to delete a repository in woodpecker which is already deleted on github.

Other forges might also be affected but I think it has to be fixed in every forge implementation itself because every forge will response differently.

see issue #5140

regards
Daniel

[qwerty287]

Thanks!

For consistency reasons, it would be nice to have this for all forges and not just github. Can you try to check it out as fas as possible? If not, we can also take a look of course. But I'd rather not merge this with only fixing the issue for github.

[tuxmainy]

For consistency reasons, it would be nice to have this for all forges and not just github. Can you try to check it out as fas as possible? If not, we can also take a look of course. But I'd rather not merge this with only fixing the issue for github.

Yeah, that would be nice. But I wonder how to do this? Every forge might have another response if the repo is already deleted. Also the error interface only has a String, thus you cannot detect specific error for all repos.

Any thoughts?

[qwerty287]

No, I'd go with the approach you used already, for github: error handling inside the forge. But this needs to be added to the other forges as well. As you said a general solution won't work.

[tuxmainy]

No, I'd go with the approach you used already, for github: error handling inside the forge. But this needs to be added to the other forges as well. As you said a general solution won't work.

I have added the same logic to gitea. But I fear I am done here. I don't have the possibility to test other forges as well and I don't like to commit code which I haven't tested before :(

[lafriks]

Would be better to use short variable names, like errr, ok := ... ( ok is common use case to check cast result etc)

[lafriks]

Would be better to use short variable names, like errr, ok := ... ( ok is common use case to check cast result etc)

[tuxmainy]

Would be better to use short variable names, like errr, ok := ... ( ok is common use case to check cast result etc)

Thanks, also make test should work now. Please keep an eye on my changes as I am not familiar with golang.