Revert "Send configuration as part of the request for external configuration"

[anbraten]

Reverts #5831

This was intentionally replaced by netrc credentials at some point as those credentials allow to load any kind of files from the forge. Allowing more powerful config extensions than just ".yml converters". We also removed this to skip internal config loading at some point for repos with a config extensions to support repos to not have a config at all (was requested for forks for example) and to avoid the extra forge api call. Also see #4341 (comment)

Unfortunately the migration seems to got lost in #4682

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.72%. Comparing base (7589e35) to head (7f029f0).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5835   +/-   ##
=======================================
  Coverage   21.72%   21.72%           
=======================================
  Files         429      429           
  Lines       38728    38730    +2     
=======================================
+ Hits         8412     8414    +2     
  Misses      29543    29543           
  Partials      773      773           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[woodpecker-bot]

Deploying preview to https://woodpecker-ci-woodpecker-pr-5835.surge.sh

[qwerty287]

Don't have time right now to write a detailed comment, please give me one or two days...

[qwerty287]

I don't know if this is the way to go. Maybe we could add a switch to allow both possibilities - include configs or not. But this would add more complexity to woodpecker again.

You're right, in the recent discussion I forgot about the more powerful usecase without yaml files. However, if you just want a simple yaml converter, it's way easier if you don't have to parse the netrc.

I thought about some more usecases that would require sending the config - e.g. chaining the config extensions - but I don't think we'll ever allow that, so that argument doesn't really count.

I don't really know what's the better way, requiring the users to include that complexity or doing that directly.

Anyways, however: This change is actually breaking. #5831 fixed how this should work according to the docs.